Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings in quickstart #1141

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

sashank27
Copy link
Contributor

Description

Fix the warnings in the quickstart of tardis.

  • tqdm does not throw a TqdmExperimentalWarning when ran on the notebook.
  • Improve the performance of dataframe slicing using presorting.

pyne.data warning is due to memory issue (under discussion)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@wkerzendorf wkerzendorf merged commit 0e085f0 into tardis-sn:master May 7, 2020
epassaro added a commit to epassaro/tardis that referenced this pull request May 27, 2020
@epassaro epassaro mentioned this pull request May 27, 2020
7 tasks
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants