Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spikes in the integrated spectrum #970

Closed
afloers opened this issue Oct 22, 2019 · 4 comments
Closed

Spikes in the integrated spectrum #970

afloers opened this issue Oct 22, 2019 · 4 comments
Labels
formal integral priority - medium

Comments

@afloers
Copy link
Contributor

afloers commented Oct 22, 2019

I ran the ddc10 model with 500,000 photon packets. Increasing the number of packets to 2.5e6 didn't solve the problem.

Problem description

In some models (e.g. DDC10) the integrated spectrum has extremely high spikes in the UV. The problem is only present in the integrated spectrum. The real spectrum doesn't suffer from this issue.

Expected Output

The integrated spectrum is shown in green, the real spectrum in orange.
Screenshot 2019-10-22 at 11 36 46
@chvogl
Copy link
Contributor

chvogl commented Oct 22, 2019

@afloers, it would be great if you could upload the configuration yaml file as well as the csvy model file; this would allow us the reproduce the problem.

@afloers
Copy link
Contributor Author

afloers commented Oct 22, 2019

tardis_config.zip
I used these files to compute the model.

@marxwillia
Copy link
Contributor

@afloers I can't download the files.

chvogl added a commit to chvogl/tardis that referenced this issue Oct 23, 2019
@chvogl
Fix formal integral spikes bug (see tardis-sn#970)
3eebc9c
@chvogl chvogl mentioned this issue Oct 23, 2019
Merged
wkerzendorf pushed a commit that referenced this issue Oct 30, 2019
@chvogl @wkerzendorf
Fix formal integral spikes bug (see #970) (#971)
76db0d6
@chvogl
Copy link
Contributor

chvogl commented Oct 30, 2019

Fixed with merge of #971.

@chvogl chvogl closed this as completed Oct 30, 2019
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this issue Oct 1, 2021
@chvogl @wkerzendorf
Fix formal integral spikes bug (see tardis-sn#970) (tardis-sn#971)
1126c55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
formal integral priority - medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marxwillia @chvogl @afloers