Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential profile - problem with units #82

Closed
ssim opened this issue Feb 14, 2014 · 2 comments
Closed

Exponential profile - problem with units #82

ssim opened this issue Feb 14, 2014 · 2 comments

Comments

@ssim
Copy link
Contributor

ssim commented Feb 14, 2014

The exponential density profile doesn't work - problem with units on the rho_0 value.

Also, a question of names: shouldn't we call this a power-law density profile?

We could also have an exponential one (i.e. rho propto exp(-v / v_0) ).

Putting these in is easy and would be useful - simple profiles that work for exponential and power-law cases are things that may be useful for many people to play with.

@mklauser
Copy link
Contributor

On 02/14/2014 01:59 PM, ssim wrote:

The exponential density profile doesn't work - problem with units on
the rho_0 value.

Also, a question of names: shouldn't we call this a power-law density
profile?

We could also have an exponential one (i.e. rho propto exp(-v / v_0) ).

Putting these in is easy and would be useful - simple profiles that
work for exponential and power-law cases are things that may be useful
for many people to play with.


Reply to this email directly or view it on GitHub
#82.

Hi,
Ad 1 The exponential density profile was never adapted to the current
version of TARDIS and hence was never tested. I guess we should fix this
function.
Ad 2 Yes, renaming the function would be reasonable .
Ad 3 Adding a new "real" exponential density profile is easy and can be
done in a few minutes (~30min).

I will take care of this problems asap ---probably on Monday.

MiChi

This was referenced Feb 18, 2014
@ssim
Copy link
Contributor Author

ssim commented Apr 15, 2014

This seems to all work now. Closing.

@ssim ssim closed this as completed Apr 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants