Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed inconsistance with prime numbers #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arthurvergacas
Copy link

  • Improved performance in the prime generation

  • Changed way that message is displayed to user

  • Removed mod function



  • A problem was occurring with prime generation: low or equal p and q resulted in wrong decryption.
  • Also improved the prime generation performance: now, it only test odd numbers
  • The mod function wasn't necessary, and could be replaced with the modulo operator (%)
  • Lastly, simply joined the characters in the final list so the user could see more clearer that the decryption was successful

Also, formated the code properly, so it's easier to read ;)

  - improved perfomance in prime generation
  - changed way tha message is displayed to user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant