Skip to content

Commit

Permalink
[mlag] fix log print sequence (sonic-net#1730)
Browse files Browse the repository at this point in the history
#### What I did
fix error log variable print sequence, otherwise it is confusable 
#### How I did it
change the varible print sequence

#### New command output (if the output of a command-line utility has changed)
before keepalive-interval setting:
```
root@sonic:/home/admin# config mclag 1 keepalive-interval 30
MCLAG Keepalive:15 Session_timeout:30 values not satisfying session_timeout >= (3 * KA)
```
after fixing:
```
root@sonic:/home/admin# config mclag 1 keepalive-interval 30
MCLAG Keepalive:30 Session_timeout:15 values not satisfying session_timeout >= (3 * KA)
```
  • Loading branch information
pettershao-ragilenetworks authored Oct 20, 2021
1 parent e600e1c commit 6595ad4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/mclag.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def mclag_ka_session_dep_check(ka, session_tmout):
"""Check if the MCLAG Keepalive timer and session timeout values are multiples of each other and keepalive is < session timeout value
"""
if not session_tmout >= ( 3 * ka):
return False, "MCLAG Keepalive:{} Session_timeout:{} values not satisfying session_timeout >= (3 * KA) ".format(session_tmout, ka)
return False, "MCLAG Keepalive:{} Session_timeout:{} values not satisfying session_timeout >= (3 * KA) ".format(ka, session_tmout)

if session_tmout % ka:
return False, "MCLAG keepalive:{} Session_timeout:{} Values not satisfying session_timeout should be a multiple of KA".format(ka, session_tmout)
Expand Down

0 comments on commit 6595ad4

Please sign in to comment.