Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cartridge container set up faster #93

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Make Cartridge container set up faster #93

merged 1 commit into from
Oct 10, 2023

Conversation

nickkkccc
Copy link
Contributor

@nickkkccc nickkkccc commented Oct 9, 2023 •
edited
Loading

The task consists of:

  • Make caching of docker images for CI
  • Optimize container cartridge image for fast assembly (rock dependencies take a long time to load)

I haven't forgotten about:

  • Tests
  • Changelog
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:
Closes for #86.

@nickkkccc nickkkccc linked an issue Oct 9, 2023 that may be closed by this pull request
Make Cartridge container set up faster #86
Closed
@nickkkccc nickkkccc requested review from akudiyar and removed request for bitgorbovsky October 9, 2023 15:52
@nickkkccc
Copy link
Contributor Author

Currently all images available in the local docker registry after passing the tests are cached.

@nickkkccc nickkkccc self-assigned this Oct 10, 2023
ArtDu
ArtDu reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@ArtDu ArtDu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's not faster than usually. Need to build rocks in image not in container as we discussed earlier. But still good job in investigation

akudiyar
akudiyar approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@akudiyar akudiyar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this caching previously, see https://github.com/tarantool/cartridge-spark/blob/master/.github/workflows/scala.yml#L41C1-L47C49
I don't remember why it was removed. Perhaps the action plugin version was just outdated and produced warnings.

@akudiyar akudiyar merged commit 63205f9 into master Oct 10, 2023
@akudiyar akudiyar deleted the gh-86 branch October 10, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtDu ArtDu ArtDu left review comments

@akudiyar akudiyar akudiyar approved these changes

Assignees

@nickkkccc nickkkccc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Cartridge container set up faster
3 participants
@nickkkccc @akudiyar @ArtDu