Fix problem if topology isn't applied correctly #70
Conversation
ArtDu
force-pushed
the
topology_error
branch
2 times, most recently
from
82f9df0 to
56da7f3
Compare
| @@ -0,0 +1,16 @@ | |||
| cartridge = require('cartridge') | |||
There was a problem hiding this comment.
q: what is incorrect in this topology?
There was a problem hiding this comment.
There's no server on 3303 port. I added comment in topology
| @@ -21,8 +26,8 @@ public class TarantoolCartridgeBootstrapFromLuaWithFixedPortsTest { | |||
| "Dockerfile", | |||
| "cartridge/instances_fixedport.yml", | |||
| "cartridge/topology_fixedport.lua") | |||
| .withCopyFileToContainer(MountableFile.forClasspathResource("cartridge"), "/app") | |||
| .withCopyFileToContainer(MountableFile.forClasspathResource("cartridge/instances_fixedport.yml"),"/app/instances.yml") | |||
| .withDirectoryBinding("cartridge") | |||
There was a problem hiding this comment.
IIRC Vova changed this line because we had some problems with windows (?) or something. Did you look at the history of this change? Is it safe to use binding here? (I know, it's the default preferred variant, but there was some problem)
There was a problem hiding this comment.
It's hard to see why it had been changed #46. I asked @dkasimovskiy to try to run tests(he has windows + wsl) but he didn't get what I want and merged PR 🤷♂️
There was a problem hiding this comment.
@akudiyar we will test how it's working with windows. You can check other PRs in testcontainers
There was a problem hiding this comment.
On the latest WSL2 it works fine.
I haven't forgotten about:
Related issues: