Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests migrations #42

Merged
merged 3 commits into from
May 13, 2022
Merged

Add tests migrations #42

merged 3 commits into from
May 13, 2022

Conversation

Voloodya
Copy link
Contributor

@Voloodya Voloodya commented May 4, 2022 •
edited
Loading

#20 Add tests migrations

vrogach2020
vrogach2020 suggested changes May 11, 2022
View reviewed changes
src/test/java/org/testcontainers/containers/TarantoolCartridgeMigrationsTest.java Outdated Show resolved Hide resolved
src/test/java/org/testcontainers/containers/TarantoolCartridgeMigrationsTest.java Outdated Show resolved Hide resolved
src/test/java/org/testcontainers/containers/TarantoolCartridgeMigrationsTest.java Outdated
}

@Test
public void test_migrations_curl(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use curl please to reduce dependencies on external modules

Copy link
Contributor Author

@Voloodya Voloodya May 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. Only standart container tools are user here
Each migration method is checked separatly, this one too

src/test/resources/cartridge/migrations/001_spase_test.lua Outdated Show resolved Hide resolved
src/test/java/org/testcontainers/containers/TarantoolCartridgeMigrationsTest.java Outdated Show resolved Hide resolved
src/test/java/org/testcontainers/containers/TarantoolCartridgeMigrationsTest.java Outdated Show resolved Hide resolved
src/test/resources/cartridge/migrations/001_spase_test.lua Outdated Show resolved Hide resolved
@Voloodya Voloodya requested a review from vrogach2020 May 12, 2022 07:12
@vrogach2020 vrogach2020 merged commit 027ab2d into tarantool:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrogach2020 vrogach2020 vrogach2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Voloodya @vrogach2020