Skip SQL tests if tarantool version < 2.0.0 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylobankov
force-pushed
the
ylobankov/skip-or-run-sql-tests
branch
3 times, most recently
from
051ca05 to
2b5ce9c
Compare
ylobankov
force-pushed
the
ylobankov/skip-or-run-sql-tests
branch
2 times, most recently
from
789478d to
2966ccf
Compare
Totktonada
reviewed
Nov 15, 2021
Totktonada
reviewed
Nov 15, 2021
|
Can I look at run logs on 1.10 somewhere? |
ylobankov
force-pushed
the
ylobankov/skip-or-run-sql-tests
branch
2 times, most recently
from
06c3c14 to
aa24697
Compare
For running tests against tarantool 1.10, I manually triggered the |
Problem: all SQL-related tests fail with the following error
if tarantool < 2.0.0 is used:
tarantool.error.DatabaseError: (48, 'Unknown request type 11')
Tarantool supports SQL-related stuff only since the 2.0.0 version.
So this patch adds a special decorator that will skip the test if
tarantool version < 2.0.0 is used.
Fixes #194
Totktonada
force-pushed
the
ylobankov/skip-or-run-sql-tests
branch
from
8bd66d4 to
6de4c53
Compare
|
(Squashed commits. Will push after CI tomorrow. Feel free to push yourself.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: all SQL-related tests fail with the following error
if tarantool < 2.0.0 is used:
Tarantool supports SQL-related stuff only since the 2.0.0 version.
So this patch adds a special decorator that will skip the test if
tarantool version < 2.0.0 is used.
Fixes #194