-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add rws_files #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for the patch.
- for consistency, we can call the tool
rws_files
. Up to you. - created file does not have any permissions (
---------- 1 leonid users 21454627 Oct 24 18:32 rws-files.txt
) - what do you think about adding several options to the CLI (
--workers
,--file
,--quiet
,--help
)
Personally I prefer tool names that doesn't require pressing the Shift key. I had an idea that there is no consistency with
It is due to tarantool/tarantool#7981. I had an idea that it is a developer tool and unlikely someone will use an old tarantool version. Anyway, it is easy to workaround. I'll do.
I don't mind, but I wouldn't go there within this pull request if you don't insist. |
ok.
I'm just using tarantool from the system (arch linux) and I think I'm not alone)
I would be happy to have options |
A simple crawler for https://rws.tarantool.org.
0c8912a
to
a21486e
Compare
@LeonidVas I've updated the patch according to the comments (except decoupling HTML parsing from the main worker logic). |
CI says:
I don't know a reason. |
A simple crawler for https://rws.tarantool.org.