Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add rws_files #84

Merged
merged 1 commit into from
Oct 16, 2024
Merged

tools: add rws_files #84

merged 1 commit into from
Oct 16, 2024

Conversation

Totktonada
Copy link
Member

A simple crawler for https://rws.tarantool.org.

Copy link
Contributor

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.

  • for consistency, we can call the tool rws_files. Up to you.
  • created file does not have any permissions (---------- 1 leonid users 21454627 Oct 24 18:32 rws-files.txt)
  • what do you think about adding several options to the CLI (--workers, --file, --quiet, --help)

tools/rws-files Outdated Show resolved Hide resolved
@Totktonada
Copy link
Member Author

  • for consistency, we can call the tool rws_files. Up to you.

Personally I prefer tool names that doesn't require pressing the Shift key.

I had an idea that there is no consistency with rws_backup.sh, because I have no .lua at the end. But that's really has no much value for me, I'll just rename the tool to rws_files.

  • created file does not have any permissions (---------- 1 leonid users 21454627 Oct 24 18:32 rws-files.txt)

It is due to tarantool/tarantool#7981.

I had an idea that it is a developer tool and unlikely someone will use an old tarantool version. Anyway, it is easy to workaround. I'll do.

  • what do you think about adding several options to the CLI (--workers, --file, --quiet, --help)

I don't mind, but I wouldn't go there within this pull request if you don't insist.

@LeonidVas
Copy link
Contributor

  • for consistency, we can call the tool rws_files. Up to you.

Personally I prefer tool names that doesn't require pressing the Shift key.

I had an idea that there is no consistency with rws_backup.sh, because I have no .lua at the end. But that's really has no much value for me, I'll just rename the tool to rws_files.

ok.

  • created file does not have any permissions (---------- 1 leonid users 21454627 Oct 24 18:32 rws-files.txt)

It is due to tarantool/tarantool#7981.

I had an idea that it is a developer tool and unlikely someone will use an old tarantool version. Anyway, it is easy to workaround. I'll do.

I'm just using tarantool from the system (arch linux) and I think I'm not alone)

  • what do you think about adding several options to the CLI (--workers, --file, --quiet, --help)

I don't mind, but I wouldn't go there within this pull request if you don't insist.

I would be happy to have options --help and --quiet.

@Totktonada Totktonada force-pushed the Totktonada/rws-files branch from 0c8912a to a21486e Compare August 22, 2024 16:54
@Totktonada
Copy link
Member Author

@LeonidVas I've updated the patch according to the comments (except decoupling HTML parsing from the main worker logic).

@Totktonada Totktonada assigned ylobankov and LeonidVas and unassigned Totktonada Aug 22, 2024
@Totktonada Totktonada requested a review from LeonidVas August 22, 2024 16:57
@Totktonada
Copy link
Member Author

CI says:

GitHub Actions has encountered an internal error when running your job.

I don't know a reason.

@Totktonada Totktonada changed the title tools: add rws-files tools: add rws_files Aug 22, 2024
@ylobankov ylobankov merged commit d535c60 into master Oct 16, 2024
1 check passed
@ylobankov ylobankov deleted the Totktonada/rws-files branch October 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants