-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support IPROTO_FEATURE_SPACE_AND_INDEX_NAMES
#345
api: support IPROTO_FEATURE_SPACE_AND_INDEX_NAMES
#345
Conversation
Right now |
The idea do not use a big 9-bytes values. I think we could choose a largest possible type (int64 or uint64 - we need recheck it) and use |
71c95e0
to
3fad5b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that we need to reconsider the tests with different resolver options. Now it is not entirely clear what is being tested and why.
As example, we need to test:
- If
NamesUseSupported() == true
+ space == "string" -> ResolveSpace() is not called by requests Body(). - If
NamesUseSupported() == true
+ space == "string" -> ResolveIndex() is not called by requests Body(). - If
NamesUseSupported() == false
+ space == "string" -> ResolveSpace() is called by requests Body() to resolve space id. - If
NamesUseSupported() == true
+ space == "string" -> ResolveIndex() is called by requests Body() to resolve index id.
It should be enough. Other tests should test what the actually test (default values, setters, invalid spaces and etc), not the behavior of resolving.
7cb1b5d
to
42e3251
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch. Just a few mirror notes to fix:
e025b0d
to
dc50888
Compare
dc50888
to
cf194a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had forgot to click "Finish your review"
cf194a9
to
e0e2b3e
Compare
Support `IPROTO_FEATURE_SPACE_AND_INDEX_NAMES` for Tarantool version >= 3.0.0-alpha1. It allows to use space and index names in requests instead of their IDs. `ResolveSpaceIndex` function for `SchemaResolver` interface split into two: `ResolveSpace` and `ResolveIndex`. `NamesUseSupported` function added into the interface to get information if usage of space and index names is supported. `Schema` structure no longer implements `SchemaResolver` interface. Part of #338
Replaced `t.Errorf` + `return` by `t.Fatalf`. This made all tests in the file follow the same code style. Part of #338
Update Tarantool EE version 1.10.11 to 1.10.15, 2.10.0 to 2.10.8 and 2.11.0 to 2.11.1. This was done because of the one flacking test: https://github.com/tarantool/go-tarantool/actions/runs/6805504621/job/18505152412 Closes #338
e0e2b3e
to
b7dd4d8
Compare
Support
IPROTO_FEATURE_SPACE_AND_INDEX_NAMES
for Tarantool version >= 3.0.0-alpha1. It allows to use space and index names in requests instead of their IDs.ResolveSpaceIndex
function forSchemaResolver
interface split into two:ResolveSpace
andResolveIndex
.NamesUseSupported
function added into the interface to get information if usage of space and index names is supported.Schema
structure no longer implementsSchemaResolver
interface.Update Tarantool EE version 1.10.11 to 1.10.15, 2.10.0 to 2.10.8 and 2.11.0 to 2.11.1. This was done because of the one flacking test: https://github.com/tarantool/go-tarantool/actions/runs/6805504621/job/18505152412
I didn't forget about (remove if it is not applicable):
Closes #338