Fix many flaky tests on macOs #292
Merged
+235
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
3 times, most recently
from
609d6bb to
6b7f1cd
Compare
|
test: wait for queue cluster |
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
6b7f1cd to
18ab3f4
Compare
Thank you, updated. |
Ttr should be in seconds. Part of #278
We don't have stable results if queue.cfg({in_replicaset = true})
is called after box.cfg(). Probably it is expected [1].
1. tarantool/queue#206
Part of #278
We need to wait for an additional events to make the test stable: 1. A ready state for a queue. 2. A success queue configuration on all instances. 3. An available RW instance. 4. A success role switch. Closes #278
An instance was listening on a testing port until the configuration was complete. At the end of the configuration, the port was reopened. As a result, we saw connection loss in tests. Closes #288
We need to wait for a successful role cluster configuration because an instance bootstrap may haven't finished yet. Part of #291
We should release the lock even if connect fails. Part of #282
oleg-jukovec
force-pushed
the
better0fdead/flaky-macOS
branch
from
18ab3f4 to
0e9ebb0
Compare
better0fdead
approved these changes
May 18, 2023
vr009
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed many flaky tests for macOs.
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #277
Closes #278
Closes #282
Closes #288
Closes #291