bugfix: watcher events loss #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goroutines could set a value to `ret` shared variable without protection. The shared variable has been replaced with a channel. Part of #284
The change helps to make the order of execution and sending of async
requests the same.
As example:
conn.Do(AsyncRequest1).Get()
conn.Do(AsyncRequest2).Get()
It is now guaranteed that AsyncRequest2 will be sent to the network
after AsyncRequest1. Before the patch the order was undefined.
Part of #284
Watchers may behave incorrectly if a request timeout is too small. A re-IPROTO_WATCH request may be not send to a server. It could lead to loss of events stream. It also could lead to a lost IPROTO_UNREGISTER request, but a user won't see the problem. Closes #284
better0fdead
approved these changes
May 16, 2023
DifferentialOrange
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchers may behave incorrectly if a request timeout is too small. A
re-IPROTO_WATCH request may be not send to a server. It could lead to
loss of events stream.
It also could lead to a lost IPROTO_UNREGISTER request, but a user
won't see the problem.
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #284