Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a lint CI job #142

Closed
DifferentialOrange opened this issue Feb 8, 2022 · 2 comments · Fixed by #160
Closed

Create a lint CI job #142

DifferentialOrange opened this issue Feb 8, 2022 · 2 comments · Fixed by #160
Assignees
Labels
feature A new functionality

Comments

@DifferentialOrange
Copy link
Member

Check Go code with some gofmt action (for example, https://github.com/golangci/golangci-lint-action) and Lua code with luacheck

@ligurio
Copy link
Member

ligurio commented Apr 7, 2022

Full list of warnings produced by golangci-lint (golangci-lint run .):

schema.go:54:19: illegal character U+0023 '#' (typecheck)
	spaceSpId  = 280 # disable the rule SA1000
	                 ^
schema.go:61:2: expected 'IDENT', found 'var' (typecheck)
	var resp *Response
	^
schema.go:69:2: expected 'IDENT', found 'if' (typecheck)
	if err != nil {
	^
schema.go:70:3: expected 'IDENT', found 'return' (typecheck)
		return err
		^
schema.go:71:2: expected 'IDENT', found '}' (typecheck)
	}
	^
schema.go:72:2: expected 'IDENT', found 'for' (typecheck)
	for _, row := range resp.Data {
	^
schema.go:79:3: expected 'IDENT', found 'if' (typecheck)
		if len(row) >= 6 {
		^
schema.go:80:4: expected 'IDENT', found 'switch' (typecheck)
			switch row5 := row[5].(type) {
			^
schema.go:84:5: expected declaration, found 'if' (typecheck)
				if temp, ok := row5["temporary"]; ok {
				^
schema.go:131:22: expected 'IDENT', found ')' (typecheck)
		switch row[4].(type) {
		                   ^
schema.go:132:14: expected ';', found ':' (typecheck)
		case uint64:
		           ^
example_test.go:19:26: undeclared name: `tarantool` (typecheck)
func example_connect() (*tarantool.Connection, error) {
                         ^
tarantool_test.go:92:12: undeclared name: `Opts` (typecheck)
var opts = Opts{
           ^
example_test.go:20:15: undeclared name: `tarantool` (typecheck)
	conn, err := tarantool.Connect(server, opts)
	             ^
example_test.go:38:12: undeclared name: `tarantool` (typecheck)
	var conn *tarantool.Connection
	          ^
tarantool_test.go:105:15: undeclared name: `Connect` (typecheck)
	conn, err := Connect(server, opts)
	             ^
tarantool_test.go:118:48: undeclared name: `IterEq` (typecheck)
		_, err = conn.Select(spaceNo, indexNo, 0, 1, IterEq, []interface{}{uint(1111)})
		                                             ^
tarantool_test.go:128:15: undeclared name: `Connect` (typecheck)
	conn, err := Connect(server, opts)
	             ^
tarantool_test.go:142:50: undeclared name: `IterEq` (typecheck)
		err = conn.SelectTyped(spaceNo, indexNo, 0, 1, IterEq, IntKey{1111}, &r)
		                                               ^
tarantool_test.go:152:15: undeclared name: `Connect` (typecheck)
	conn, err := Connect(server, opts)
	             ^
tarantool_test.go:165:14: undeclared name: `Future` (typecheck)
		var fs [N]*Future
		           ^
tarantool_test.go:167:53: undeclared name: `IterEq` (typecheck)
			fs[j] = conn.SelectAsync(spaceNo, indexNo, 0, 1, IterEq, []interface{}{uint(1111)})
			                                                 ^
tarantool_test.go:195:14: undeclared name: `Future` (typecheck)
		var fs [N]*Future
		           ^
tarantool_test.go:230:15: undeclared name: `Future` (typecheck)
			var fs [N]*Future
			           ^
tarantool_test.go:391:12: undeclared name: `Response` (typecheck)
	var resp *Response
	          ^
tarantool_test.go:393:12: undeclared name: `Connection` (typecheck)
	var conn *Connection
	          ^
tarantool_test.go:441:24: undeclared name: `Error` (typecheck)
	if tntErr, ok := err.(Error); !ok || tntErr.Code != ErrTupleFound {
	                      ^
tarantool_test.go:698:12: undeclared name: `Connection` (typecheck)
	var conn *Connection
	          ^
tarantool_test.go:719:21: undeclared name: `Space` (typecheck)
	var space, space2 *Space
	                   ^
tarantool_test.go:759:48: undeclared name: `Field` (typecheck)
	var field1, field2, field5, field1n, field5n *Field
	                                              ^
tarantool_test.go:805:40: undeclared name: `Index` (typecheck)
	var index0, index3, index0n, index3n *Index
	                                      ^
tarantool_test.go:880:12: undeclared name: `Response` (typecheck)
	var resp *Response
	          ^
tarantool_test.go:882:12: undeclared name: `Connection` (typecheck)
	var conn *Connection
	          ^
example_test.go:7:2: "github.com/tarantool/go-tarantool" imported but not used (typecheck)
	"github.com/tarantool/go-tarantool"
	^
tarantool_test.go:12:2: "github.com/tarantool/go-tarantool" imported but not used (typecheck)
	. "github.com/tarantool/go-tarantool"
	^

I'm not sure that we should fix all these warnings.

vr009 added a commit that referenced this issue Apr 8, 2022
@vr009 vr009 mentioned this issue Apr 8, 2022
ligurio added a commit that referenced this issue Apr 8, 2022
ligurio added a commit that referenced this issue Apr 8, 2022
luacheck config has been already added in commit
'lua: fix code style in test scripts' (17b725f).
As well as fixes for warnings found by luacheck.

Part of #142
ligurio added a commit that referenced this issue Apr 8, 2022
ligurio added a commit that referenced this issue Apr 12, 2022
luacheck config has been already added in commit
'lua: fix code style in test scripts' (17b725f).
As well as fixes for warnings found by luacheck.

Part of #142
ligurio added a commit that referenced this issue Apr 12, 2022
ligurio added a commit that referenced this issue Apr 12, 2022
ligurio added a commit that referenced this issue Apr 12, 2022
luacheck config has been already added in commit
'lua: fix code style in test scripts' (17b725f).
As well as fixes for warnings found by luacheck.

Part of #142
ligurio added a commit that referenced this issue Apr 12, 2022
ligurio added a commit that referenced this issue Apr 12, 2022
ligurio added a commit that referenced this issue Apr 12, 2022
luacheck config has been already added in commit
'lua: fix code style in test scripts' (17b725f).
As well as fixes for warnings found by luacheck.

Part of #142
ligurio added a commit that referenced this issue Apr 12, 2022
@ligurio ligurio removed their assignment Apr 12, 2022
@ligurio
Copy link
Member

ligurio commented Apr 12, 2022

@vr009 Workflow with luacheck and golangci-lint has been merged in PR #154

vr009 added a commit that referenced this issue Apr 13, 2022
vr009 added a commit that referenced this issue Apr 13, 2022
vr009 added a commit that referenced this issue Apr 13, 2022
vr009 added a commit that referenced this issue Apr 13, 2022
vr009 added a commit that referenced this issue Apr 13, 2022
vr009 added a commit that referenced this issue Apr 13, 2022
Removed error's suppression in check.yaml.

Relates to #142
vr009 added a commit that referenced this issue Apr 20, 2022
Removed error's suppression in check.yaml.

Suppressed the highlighting of errorcheck in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface. For future, if the implementation of writer
will be changed, and we will have to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced some calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code.

Suppressed the highlighting of all unused constants and functions.

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Relates to #142
vr009 added a commit that referenced this issue Apr 20, 2022
Removed error's suppression in check.yaml.

Suppressed the highlighting of errorcheck in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface. For future, if the implementation of writer
will be changed, and we will have to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced some calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code.

Suppressed the highlighting of all unused constants and functions.

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Relates to #142
vr009 added a commit that referenced this issue Apr 20, 2022
Removed error's suppression in check.yaml.

Suppressed the highlighting of errorcheck in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface. For future, if the implementation of writer
will be changed, and we will have to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced some calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code.

Suppressed the highlighting of all unused constants and functions.

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Relates to #142
vr009 added a commit that referenced this issue Apr 20, 2022
Removed error's suppression in check.yaml.

Suppressed the highlighting of errorcheck in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface. For future, if the implementation of writer
will be changed, and we will have to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced some calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code.

Suppressed the highlighting of all unused constants and functions.

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Relates to #142
vr009 added a commit that referenced this issue Apr 26, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after fixing errors check in all methods
with calling encodeXxx inside. See details below.
The rules `structcheck` and `unused` highlight the 'hack' with using
_msgpack struct{} `msgpack:",asArray"`. The workaround with `//nolint`
is not the best way to suppress it, cause this comment gets rendered
by godoc and there is no way to make it invisible. For details see
golang/go#20925.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions
(Rules structcheck,unused in golangci-lint).

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 26, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after fixing errors check in all methods
with calling encodeXxx inside. See details below.
The rules `structcheck` and `unused` highlight the 'hack' with using
_msgpack struct{} `msgpack:",asArray"`. The workaround with `//nolint`
is not the best way to suppress it, cause this comment gets rendered
by godoc and there is no way to make it invisible. For details see
golang/go#20925.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions
(Rules structcheck,unused in golangci-lint).

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 26, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after fixing errors check in all methods
with calling encodeXxx inside. See details below.
The rules `structcheck` and `unused` highlight the 'hack' with using
_msgpack struct{} `msgpack:",asArray"`. The workaround with `//nolint`
is not the best way to suppress it, cause this comment gets rendered
by godoc and there is no way to make it invisible. For details see
golang/go#20925.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions
(Rules structcheck,unused in golangci-lint).

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 26, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after fixing errors check in all methods
with calling encodeXxx inside. See details below.
The rules `structcheck` and `unused` highlight the 'hack' with using
_msgpack struct{} `msgpack:",asArray"`. The workaround with `//nolint`
is not the best way to suppress it, cause this comment gets rendered
by godoc and there is no way to make it invisible. For details see
golang/go#20925.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions
(Rules structcheck,unused in golangci-lint).

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 26, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after fixing errors check in all methods
with calling encodeXxx inside. See details below.
The rules `structcheck` and `unused` highlight the 'hack' with using
_msgpack struct{} `msgpack:",asArray"`. The workaround with `//nolint`
is not the best way to suppress it, cause this comment gets rendered
by godoc and there is no way to make it invisible. For details see
golang/go#20925.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions
(Rules structcheck,unused in golangci-lint).

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 26, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after adding errors check in all methods
with calling encodeXxx inside. See details below.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 26, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after adding errors check in all methods
with calling encodeXxx inside. See details below.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after adding errors check in all methods
with calling encodeXxx inside. See details below.

Suppressed the highlighting of error check in all methods,
having encodeXxx inside. For now these methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API, all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests. That change
prevents nil dereferences below in the code and stops test function
execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions

Fixed calling of Fatalf from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed error's suppression in check.yaml. The suppression of rule
`errcheck` may be removed after adding the errors check in all methods
with calling encodeXxx inside. See details below.

Suppressed the highlighting of the error check in all methods,
having encodeXxx inside. For now those methods are not able to
return any error cause of internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of the writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely'.

Fixed the use of time package API in all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of the Errorf() with Fatalf() in tests, where it is
needed. That change prevents nil dereferences below in the code and
stops the test execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions

Fixed the calling of Fatalf() from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed the gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed the warning's suppression in check.yaml. The suppression of rule
errcheck may be removed after adding the errors check in all methods
with calling encodeXxx inside. See details below.

Suppressed the highlighting lacks of error's check in all methods,
having encodeXxx inside. For now those methods are not able to
return any error due to internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of the writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely' for saving performance
(If there will be any affect on it).

Fixed the use of time package API in all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of the Errorf() with Fatalf() in tests, where it is
needed. That change prevents nil dereferences below in the code and
stops the test execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions

Fixed the calling of Fatalf() from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed the gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed the warning's suppression in check.yaml. The suppression of rule
errcheck may be removed after adding errors check in all methods
with calling encodeXxx inside. See details below.

Suppressed the highlighting lacks of error's check in all methods,
having encodeXxx inside. For now those methods are not able to
return any error due to internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of the writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely' for saving performance
(If there will be any affect on it).

Fixed the use of time package API in all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of the Errorf() with Fatalf() in tests, where it is
needed. That change prevents nil dereferences below in the code and
stops the test execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions

Fixed the calling of Fatalf() from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed the gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed the warning's suppression in check.yaml. The suppression
of the rule errcheck may be removed after adding errors check
in all methods calling encodeXxx inside. See details below.

Suppressed the highlighting lacks of error's check in all methods,
having encodeXxx inside. For now those methods are not able to
return any error due to internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of the writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely' for keeping performance
(If there will be any affect on it).

Fixed the use of time package API in all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests, where it is
needed. That change prevents nil dereferences below in the code and
stops the test execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions with //nolint comment.

Fixed the calling of Fatalf() from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed the gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed the warning's suppression in check.yaml. The suppression
of the rule errcheck may be removed after adding errors check
in all methods calling encodeXxx inside. See details below.

Suppressed the highlighting lacks of error's check in all methods,
having encodeXxx inside. For now those methods are not able to
return any error due to internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of the writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely' for keeping performance
(If there will be any affect on it).

Fixed the use of time package API in all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests, where it is
needed. That change prevents nil dereferences below in the code and
stops the test execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions with //nolint comment.

Fixed the calling of Fatalf() from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed the gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed the warning's suppression in check.yaml. The suppression
of the rule errcheck may be removed after adding errors check
in all methods calling encodeXxx inside. See details below.

Suppressed the highlighting lacks of error's check in all methods,
having encodeXxx inside. For now those methods are not able to
return any error due to internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of the writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely' for keeping performance
(If there will be any affect on it).

Fixed the use of time package API in all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests, where it is
needed. That change prevents nil dereferences below in the code and
stops the test execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions with //nolint comment.

Fixed the calling of Fatalf() from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed the gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
vr009 added a commit that referenced this issue Apr 28, 2022
Changed the warning's suppression in check.yaml. The suppression
of the rule errcheck may be removed after adding errors check
in all methods calling encodeXxx inside. See details below.

Suppressed the highlighting lacks of error's check in all methods,
having encodeXxx inside. For now those methods are not able to
return any error due to internal implementation of writer
interface (see smallbuf.go). For future, if the implementation of the writer
will be changed, and there will be a need to check errors, we must think
about how to say to compiler that the error check is 'unlikely' for keeping performance
(If there will be any affect on it).

Fixed the use of time package API in all places with calls of
time.Now().Sub(). Now time package propose the explicit time.Until().

Replaced all calls of Errorf() with Fatalf() in tests, where it is
needed. That change prevents nil dereferences below in the code and
stops the test execution, where it is expected in tests.

Suppressed the highlighting of all unused constants and functions with //nolint comment.

Fixed the calling of Fatalf() from non-testing goroutine in queue tests.
It is not a valid way to stop test from another goroutine.

Fixed the gofmt-highlighted places in test_helpers/pool_helper.go and
connection_pool/const.go.

Added instructions to CONTRIBUTING.md how to run CI-linter locally.

Closes #142
Closes #150
ligurio added a commit to tarantool/doc that referenced this issue May 6, 2022
ligurio added a commit to tarantool/doc that referenced this issue May 11, 2022
ligurio added a commit to tarantool/doc that referenced this issue May 11, 2022
patiencedaur pushed a commit to tarantool/doc that referenced this issue May 16, 2022
patiencedaur added a commit to tarantool/doc that referenced this issue May 16, 2022
…nalysis) (#2860)

* Update go-tarantool in comparison table

Follows up tarantool/go-tarantool#142
Follows up tarantool/go-tarantool#123

* Update translation

Co-authored-by: Patience Daur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants