create: replace vfs with embed #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
Looks like a breaking change. Can you clarify, whether it discards support of some Go versions? |
DifferentialOrange
force-pushed
the
embeded-fs
branch
2 times, most recently
from
ac9ec68 to
715a416
Compare
DifferentialOrange
added a commit
that referenced
this pull request
Jan 12, 2022
To solve #631 issue, we need to use Go with fixed embedding of folders for case when only contents are files starting with dot [1]. It should be introduced in Go 1.18, but it is not released yet. 1. golang/go#43854 Part of #637
DifferentialOrange
force-pushed
the
embeded-fs
branch
from
126f023 to
7019bb4
Compare
|
Maybe it should wait until Go 1.18 stable release, but I'll press review request button since it works |
DifferentialOrange
added a commit
that referenced
this pull request
Jan 27, 2022
To solve #631 issue, we need to use Go with fixed embedding of folders for case when only contents are files starting with dot [1]. It should be introduced in Go 1.18, but it is not released yet. 1. golang/go#43854 Part of #637
DifferentialOrange
force-pushed
the
embeded-fs
branch
from
7019bb4 to
56a6414
Compare
Totktonada
approved these changes
Jan 31, 2022
DifferentialOrange
force-pushed
the
embeded-fs
branch
from
56a6414 to
b07b189
Compare
|
Do we include internal changes like this in CHANGELOG or should it only include changes that affect binary artifact user? |
|
@LeonidVas it's relevant again |
To solve #631 issue, we need to use Go with fixed embedding of folders for case when only contents are files starting with dot [1]. The fix was introduced in Go 1.18. 1. golang/go#43854 Part of #631
Since Go 1.16, it is possible to use "embed" library to work with virtual file systems. We use one for templates in ``cartridge create``. Before this patch, we used third party library [1]. Now it's replaced with "embed". To support embedding folder which only contents are file starting with dot, we need to use Go 1.18. Moreover, file with "|" symbol in name considered to be invalid [2] and its embedding is not supported. So approach from #612 was reworked to use lowered app name as variable instead of transforming it with Funcs. Directories in vfs now have "dr-xr-xr-x" permissions instead of "drwxr-xr-x", so we change it on template build (otherwise it would be impossible to create subdirectories and files in directories). Running ``go mod tidy`` regrouped go.mod contents, together with cleaning up [1] dependency. 1. https://github.com/shurcooL/vfsgen 2. https://cs.opensource.google/go/x/mod/+/refs/tags/v0.5.1:module/module.go;l=488 Closes #631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked by @DifferentialOrange
Go requirement was bumped to
1.18.To solve #631 issue, we need to use Go with fixed embedding of
folders for case when only contents are files starting with dot [1].
The fix was introduced in Go 1.18.
Since Go 1.16, it is possible to use "embed" library to work with
virtual file systems. We use one for templates in
cartridge create.Before this patch, we used third party library [2]. Now it's replaced
with "embed".
To support embedding folder which only contents are file starting with
dot, we need to use Go 1.18. Moreover, file with "|" symbol in name
considered to be invalid [3] and its embedding is not supported.
So approach from #612 was reworked to use lowered app name as variable
instead of transforming it with Funcs.
Directories in vfs now have "dr-xr-xr-x" permissions instead of
"drwxr-xr-x", so we change it on template build (otherwise it would be
impossible to create subdirectories and files in directories).
Running
go mod tidyregrouped go.mod contents, together withcleaning up [2] dependency.
Closes #631