Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update react native types package #69

Merged
merged 1 commit into from
Jul 14, 2023
Merged

chore: update react native types package #69

merged 1 commit into from
Jul 14, 2023

Conversation

jsalaber
Copy link
Contributor

Description

Fix error not being able to use remove as the return type of addEventListener is void by updating types package.

Notable Changes

PR Checklist

  • PR title follows the format of [JIRA-TICKET-NUMBER/Ad-hoc]: [Short of PR]
    • Example:
      • TAP-1234: Added GitHub templates
      • Ad-hoc: Fixed linter command
  • Testing - New feature
    • N/A
    • OR
    • Make sure you've added a new test to the test-repo if existing tests do not effectively test the code changed. Also ensure that the tests are captured within the Testing Strategy Doc.

@jsalaber jsalaber merged commit c5dae7c into master Jul 14, 2023
@jsalaber jsalaber deleted the update-types branch July 14, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantalchung chantalchung chantalchung approved these changes

@nikolasleblanc nikolasleblanc Awaiting requested review from nikolasleblanc

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsalaber @chantalchung