Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative TAP command support #20

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jtlapp
Copy link

@jtlapp jtlapp commented Aug 3, 2016

This is a PR for proposal #19. It contains everything described in that request, plus one thing.

This version of faucet also supports the word "assertions" appearing in place of "tests" in the output summary. The word "tests" is still allowed. See this tape issue for an explanation. I currently have tapeo patching tape to say "assertions" instead (but patching is not stable long-term).

@jtlapp
Copy link
Author

jtlapp commented Aug 5, 2016

I've added to this PR a way for faucet to support TAP bail outs without having the support of the old version of tap-parser it relies on. My underlying TAP command can emit bail outs. See #21

@ljharb
Copy link
Collaborator

ljharb commented Sep 22, 2022

I don't think there's any value in supporting the word "assertions" when tape and TAP itself both don't.

If that can be removed, and there's still value in the rest of the PR, I'd love to see it rebased so it can be landed.

@ljharb ljharb marked this pull request as draft September 22, 2022 05:22
@ljharb

This comment was marked as resolved.

@jtlapp
Copy link
Author

jtlapp commented Sep 22, 2022

I posted this 6 years ago and no longer even remember what this is about. If you're dependent on me to do anything with this, then you might as well close it. I'll be unsubscribing from it.

@ljharb

This comment was marked as resolved.

@ljharb
Copy link
Collaborator

ljharb commented Sep 22, 2022

For the record, I only recently took over maintenance of this package, and I apologize that the previous maintainer let it sit ignored for so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants