Provide a better default appender when running under nodejs. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The console appender doesn't work the same way under nodejs and the println appender seems a better choice.
Hi @sundbp, could you please provide some more context for this? In what way is it different? And in what way would the println appender by better? Thanks! |
|
It's a while since I made this PR now, so don't recall if the console appender is a no-op or actually fails under nodejs. Best memory is that was a no-op. So console appender fine in browser, but not under nodejs. |
|
Merging manually, thanks! |
ptaoussanis
added a commit
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console appender doesn't work the same way under nodejs and the println
appender seems a better default choice.