Use java.util.concurrent.ExecutorService/submit instead of future
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(future) starts the agent threadpool, which slows down shutdown unless (shutdown-agents) is called.
|
Hi Ryan, fantastic- thank you! |
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 15, 2015
…ture` (@ryfow) (future) starts the agent threadpool, which slows down shutdown unless (shutdown-agents) is called.
ptaoussanis
added a commit
that referenced
this pull request
Dec 15, 2015
|
Have pushed |
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 15, 2015
…ture` (@ryfow) (future) starts the agent threadpool, which slows down shutdown unless (shutdown-agents) is called.
ptaoussanis
added a commit
that referenced
this pull request
Dec 15, 2015
|
Glad to help. I never noticed the problem until I added slf4j-timbre. Somehow that was triggering the agents during compile which was adding a long pause between compile and running things with I always |
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 22, 2015
…ture` (@ryfow) (future) starts the agent threadpool, which slows down shutdown unless (shutdown-agents) is called.
ptaoussanis
added a commit
that referenced
this pull request
Dec 22, 2015
ptaoussanis
pushed a commit
that referenced
this pull request
Dec 27, 2015
…ture` (@ryfow) (future) starts the agent threadpool, which slows down shutdown unless (shutdown-agents) is called.
ptaoussanis
added a commit
that referenced
this pull request
Dec 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(future) starts the agent threadpool, which slows down shutdown
unless (shutdown-agents) is called.
This resolves #61.