Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClojureScript spit-appender #308

Closed
mavines opened this issue Jun 4, 2020 · 3 comments
Closed

ClojureScript spit-appender #308

mavines opened this issue Jun 4, 2020 · 3 comments
Labels
community appenders pull requests welcome

Comments

@mavines
Copy link

mavines commented Jun 4, 2020

I've modified spit-appender to work in ClojureScript on Node. It adds a dependency on cljs-node-io and won't work in the browser. Would it be better to add this to core.cljx or as a third-party appender (or not at all)?
@ptaoussanis
Copy link
Member

Hi @mavines - PR welcome to add as 3rd party appender, thanks!

@josephwinston
Copy link

@mavines would it be possible to share the repo or the patch as I have a need for the spit-appender in ClojureScript?

@mavines mavines mentioned this issue Sep 24, 2020
Closed
ptaoussanis pushed a commit that referenced this issue Sep 24, 2020
@ptaoussanis
[#308 #320] Add cljs spit-appender 3rd-party appender for running on …
57fa1ad 
…node (@mavines)
@ptaoussanis
Copy link
Member

Merged, thanks!

ptaoussanis pushed a commit that referenced this issue Sep 27, 2020
@ptaoussanis
[#308 #320] Add cljs spit-appender 3rd-party appender for running on …
bc866bd 
…node (@mavines)
ptaoussanis pushed a commit that referenced this issue Oct 1, 2020
@ptaoussanis
[#308 #320] Add cljs spit-appender 3rd-party appender for running on …
791f8b2 
…node (@mavines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community appenders pull requests welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding a CLJS spit_appender for running on node. mavines/timbre
3 participants
@ptaoussanis @josephwinston @mavines