New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newrelic namespace has name that doesn't correspond with its file name #246

Closed

jafingerhut opened this issue Oct 10, 2017 · 1 comment

Labels

bug

jafingerhut commented Oct 10, 2017

The namespace name here: https://github.com/ptaoussanis/timbre/blob/master/src/taoensso/timbre/appenders/3rd_party/newrelic.clj#L1

is taoensso.timbre.appenders.3rd-party.appenders.newrelic

Its file name suggests that the namespace should instead be: taoensso.timbre.appenders.3rd-party.newrelic

Files containing namespaces with "mismatched" names can cause problems for tools like Leiningen, or sometimes for Clojure's require

ptaoussanis added the bug label

Member

ptaoussanis commented Apr 15, 2018

Thanks Andy, this was a typo- fixed on master!

ptaoussanis closed this as completed

ptaoussanis added a commit that referenced this issue


          [#246] [3rd-party appender] Newrelic: fix ns typo (@jafingerhut)

68673fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment