Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile exception with 4.2.0 #146

Closed
nicferrier opened this issue Dec 31, 2015 · 10 comments
Closed

compile exception with 4.2.0 #146

nicferrier opened this issue Dec 31, 2015 · 10 comments
Labels

Comments

@nicferrier
Copy link

<CompilerException java.lang.IllegalArgumentException: More than one matching method found: submit, compiling:(taoensso/timbre.clj:568:16)>

which means here: https://github.com/ptaoussanis/timbre/blob/master/src/taoensso/timbre.cljx#L568

I've no idea why this would show as a problem. Seems weird?

@ptaoussanis
Copy link
Member

Hi Nic, please provide further details?

How are you compiling? What version of Clojure are you using? What JVM version? Any particular behaviour triggering this?

Thanks

@nicferrier
Copy link
Author

Clojure 1.6.0 on Java HotSpot(TM) Client VM 1.8.0_25-b18

I'm just using: lein repl on a project for which timbre 3 was working fine. When the repl comes up I get this error, obviously as part of it bringing in the deps?

ptaoussanis added a commit that referenced this issue Jan 3, 2016
Having difficulty reproducing the error described by the GitHub issue.

Figure the cause might have something to do with attaching the type info
to the (fn []) form? The approach as of this commit seems like it'd be
less likely to trip up the compiler.
@ptaoussanis
Copy link
Member

Hi Nic,

I haven't been able to reproduce this on my end. As a random idea, trying one change that might help.

Please confirm if that fixes the issue on your end? Otherwise you may need you to provide a reproducible repo that I can look at.

Note: tried to upload the change to Clojars but looks like they're still down due to the Linode DDoS attack. You'll unfortunately need to use a local Timbre copy:

  1. git clone https://github.com/ptaoussanis/timbre.git
  2. git checkout dev
  3. Mod the project.clj version to something like 4.2.1-SNAPSHOT
  4. lein build-once to build your custom version of Timbre
  5. lein install to install it to your local Maven repo
  6. Include the same version string in your project's dependencies

Thanks again for the report

@nicferrier
Copy link
Author

Well, it occurs to me that maybe I didn't get a download because of the DDoS. I didn't notice any error like that. So I'll try this next week and maybe they'll be ok then.

@rdanitz
Copy link

rdanitz commented Jan 7, 2016

I got the same error although 4.2.0 worked for me before.
I could fix it by upgrading from clojure 1.6.0 to 1.7.0, everything else being the same.

@ptaoussanis
Copy link
Member

@rdanitz Hi Robert, could you please clarify: 4.2.0 worked for you before what?

@ptaoussanis
Copy link
Member

@rdanitz Oh, also- any chance you could possibly confirm whether [com.taoensso/timbre "4.2.1-SNAPSHOT"] solves the problem for you with Clojure 1.6? (The snapshot is now up on Clojars)

Thanks!

@rdanitz
Copy link

rdanitz commented Jan 8, 2016

@ptaoussanis 4.2.1-SNAPSHOT works with clojure 1.6.0 now.
Sorry for the confusion, I only checked 4.2.0 with clojure 1.7.0 before. My remark was regarding clojure 1.7.0.

@ptaoussanis
Copy link
Member

@rdanitz Awesome, thanks for confirming!

@ptaoussanis
Copy link
Member

Closing this with the release of https://github.com/ptaoussanis/timbre/releases/tag/v4.2.1

Josh-Tilles pushed a commit to Josh-Tilles/timbre that referenced this issue Apr 30, 2016
Having difficulty reproducing the error described by the GitHub issue.

Figure the cause might have something to do with attaching the type info
to the (fn []) form? The approach as of this commit seems like it'd be
less likely to trip up the compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants