fix(#378): fix runtime error on execution

lua/vgit/controller.lua

@@ -115,7 +115,7 @@ local toggle_live_gutter = loop.coroutine(function()
   local live_gutter_enabled = live_gutter_setting:get('enabled')
 
   live_gutter_setting:set('enabled', not live_gutter_enabled)
-  live_gutter:reset()
+  live_gutter:toggle()
 end)
 
 local toggle_tracing = loop.coroutine(function()

lua/vgit/features/buffer/Hunks.lua

@@ -4,6 +4,7 @@ local Object = require('vgit.core.Object')
 local console = require('vgit.core.console')
 local navigation = require('vgit.core.navigation')
 local git_buffer_store = require('vgit.git.git_buffer_store')
+local live_gutter_setting = require('vgit.settings.live_gutter')
 
 local Hunks = Object:extend()
 
@@ -13,7 +14,13 @@ function Hunks:constructor()
   }
 end
 
+function Hunks:is_enabled()
+  return live_gutter_setting:get('enabled') == true
+end
+
 function Hunks:move_up()
+  if not self:is_enabled() then return end
+
   local buffer = git_buffer_store.current()
   if not buffer then return end
 
@@ -25,6 +32,8 @@ function Hunks:move_up()
 end
 
 function Hunks:move_down()
+  if not self:is_enabled() then return end
+
   local buffer = git_buffer_store.current()
   if not buffer then return end
 
@@ -67,7 +76,7 @@ function Hunks:stage_all()
 end
 
 function Hunks:cursor_stage()
-  loop.free_textlock()
+  if not self:is_enabled() then return end
 
   local buffer = git_buffer_store.current()
   if not buffer then return end
@@ -114,6 +123,8 @@ function Hunks:reset_all()
 end
 
 function Hunks:cursor_reset()
+  if not self:is_enabled() then return end
+
   loop.free_textlock()
   local buffer = git_buffer_store.current()
   if not buffer then return end
@@ -144,8 +155,8 @@ function Hunks:cursor_reset()
   for i = 1, #hunks do
     local hunk = hunks[i]
     if
-      (lnum >= hunk.top and lnum <= hunk.bot)
-      or (hunk.top == 0 and hunk.bot == 0 and lnum - 1 == hunk.top and lnum - 1 == hunk.bot)
+        (lnum >= hunk.top and lnum <= hunk.bot)
+        or (hunk.top == 0 and hunk.bot == 0 and lnum - 1 == hunk.top and lnum - 1 == hunk.bot)
     then
       selected_hunk = hunk
       selected_hunk_index = i

lua/vgit/features/buffer/LiveGutter.lua

@@ -1,8 +1,6 @@
 local loop = require('vgit.core.loop')
-local utils = require('vgit.core.utils')
 local Object = require('vgit.core.Object')
 local console = require('vgit.core.console')
-local buffer_store = require('vgit.core.buffer_store')
 local git_buffer_store = require('vgit.git.git_buffer_store')
 local live_gutter_setting = require('vgit.settings.live_gutter')
 
@@ -12,9 +10,11 @@ function LiveGutter:constructor()
   return { name = 'Live Gutter' }
 end
 
-function LiveGutter:fetch(buffer)
-  if not live_gutter_setting:get('enabled') then return end
+function LiveGutter:is_enabled()
+  return live_gutter_setting:get('enabled') == true
+end
 
+function LiveGutter:fetch(buffer)
   loop.free_textlock()
   if not buffer:is_valid() then return end
 
@@ -33,28 +33,36 @@ LiveGutter.fetch_debounced = loop.debounce_coroutine(function(self, buffer)
   self:fetch(buffer)
 end, 10)
 
-function LiveGutter:reset()
-  local buffers = buffer_store.list()
-  utils.list.for_each(buffers, function(buffer)
-    buffer:clear_signs()
+function LiveGutter:toggle()
+  git_buffer_store.for_each(function(buffer)
+    if self:is_enabled() then
+      self:fetch(buffer)
+    else
+      buffer:reset_signs()
+    end
+    buffer:render_signs()
   end)
 end
 
 function LiveGutter:register_events()
   git_buffer_store
-    .on({ 'attach', 'reload' }, function(buffer)
-      self:fetch(buffer)
-      buffer:render_signs()
-    end)
-    .on({ 'change' }, function(buffer)
-      self:fetch_debounced(buffer)
-    end)
-    .on('sync', function(buffer)
-      self:fetch_debounced(buffer)
-    end)
-    .on('detach', function(buffer)
-      buffer:clear_extmarks()
-    end)
+      .on({ 'attach', 'reload' }, function(buffer)
+        if not self:is_enabled() then return end
+
+        self:fetch(buffer)
+        buffer:render_signs()
+      end)
+      .on({ 'change' }, function(buffer)
+        if not self:is_enabled() then return end
+        self:fetch_debounced(buffer)
+      end)
+      .on('sync', function(buffer)
+        if not self:is_enabled() then return end
+        self:fetch_debounced(buffer)
+      end)
+      .on('detach', function(buffer)
+        buffer:clear_extmarks()
+      end)
 end
 
 return LiveGutter

lua/vgit/git/GitBuffer.lua

@@ -50,6 +50,11 @@ function GitBuffer:sync()
   return self
 end
 
+function GitBuffer:reset_signs()
+  self.state.signs = {}
+  return self
+end
+
 function Buffer:clear_conflicts(top, bot)
   top = top or 0
   bot = bot or -1