Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't rely on weakref being null, fix blobcache #9

Merged
merged 1 commit into from
Mar 17, 2016
Merged

don't rely on weakref being null, fix blobcache #9

merged 1 commit into from
Mar 17, 2016

Conversation

tanmaykm
Copy link
Owner

  • Checking weakref value to be null as an indicator of gc is not reliable. We probably need a finalizer for that, but all finalizers don't get called immediately at the moment (ref: Free objects with finalizer more eagerly JuliaLang/julia#13995). Going without that optimization for now.
  • fixed an issue where cache eviction was corrupting the cache

@tanmaykm
don't rely on weakref being null, fix blobcache
2cca130 
- Checking weakref value to be null as an indicator of gc is not reliable. We probably need a finalizer for that, but all finalizers don't get called immediately at the moment (ref: JuliaLang/julia#13995). Going without that optimization for now.
- fixed an issue where cache eviction was corrupting the cache
tanmaykm added a commit that referenced this pull request Mar 17, 2016
@tanmaykm
Merge pull request #9 from tanmaykm/tanmaykm
120158c 
don't rely on weakref being null, fix blobcache
@tanmaykm tanmaykm merged commit 120158c into master Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tanmaykm