Corrected setup of dbsize for virtual assistants (nightscout#6270)

* Corrected db size config for virtual assistants * Language fix, improvements, added dbsize to virtAsst config * Using env * Added logging * Debug logging * Different logging * More troubleshooting * Another try * Reverted stuff, added dbsize to server defaults * Fixed test * Fixed another test
tanja3981 · Nov 15, 2020 · 87b6fff · 87b6fff
1 parent ef9e379
commit 87b6fff
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 18 deletions.
diff --git a/docs/plugins/alexa-templates/en-us.json b/docs/plugins/alexa-templates/en-us.json
@@ -233,6 +233,16 @@
                             "name": {
                                 "value": "cgm mode"
                             }
+                        },
+                        {
+                            "name": {
+                                "value": "db size",
+                                "synonyms": [
+                                    "database size",
+                                    "data size",
+                                    "file size"
+                                ]
+                            }
                         }
                     ]
                 }

diff --git a/docs/plugins/google-home-templates/en-us.zip b/docs/plugins/google-home-templates/en-us.zip
diff --git a/lib/language.js b/lib/language.js
@@ -15133,7 +15133,7 @@ function init() {
       ,nl: 'Datagrootte'
     },
     'virtAsstDatabaseSize': {
-      en: '%1 MiB that is %2% of available database space'
+      en: '%1 MiB. That is %2% of available database space.'
       ,pl: '%1 MiB co stanowi %2% przestrzeni dostępnej dla bazy danych'
       ,nl: '%1 MiB dat is %2% van de beschikbaare database ruimte'
     },

diff --git a/lib/plugins/dbsize.js b/lib/plugins/dbsize.js
@@ -119,9 +119,9 @@ function init (ctx) {
 
   function virtAsstDatabaseSizeHandler (next, slots, sbx) {
     var display = _.get(sbx, 'properties.dbsize.display');
-    var dataSize = _.get(sbx, 'properties.dbsize.details.dataSize');
-    var dataPercentage = _.get(sbx, 'properties.dbsize.dataPercentage');
     if (display) {
+      var dataSize = _.get(sbx, 'properties.dbsize.details.dataSize');
+      var dataPercentage = _.get(sbx, 'properties.dbsize.dataPercentage');
       var response = translate('virtAsstDatabaseSize', {
         params: [
           dataSize
@@ -137,13 +137,8 @@ function init (ctx) {
   dbsize.virtAsst = {
     intentHandlers: [
       {
-        // for backwards compatibility
-        intent: 'DatabaseSize'
-        , intentHandler: virtAsstDatabaseSizeHandler
-      }
-      , {
         intent: 'MetricNow'
-        , metrics: ['database size', 'file size', 'db size', 'data size']
+        , metrics: ['db size']
         , intentHandler: virtAsstDatabaseSizeHandler
       }
     ]

diff --git a/lib/plugins/index.js b/lib/plugins/index.js
@@ -74,6 +74,7 @@ function init (ctx) {
     , require('./treatmentnotify')(ctx)
     , require('./timeago')(ctx)
     , require('./basalprofile')(ctx)
+    , require('./dbsize')(ctx)
   ];
 
   plugins.registerServerDefaults = function registerServerDefaults () {

diff --git a/lib/plugins/virtAsstBase.js b/lib/plugins/virtAsstBase.js
@@ -81,7 +81,7 @@ function init(env, ctx) {
   };
 
   virtAsstBase.setupVirtAsstHandlers = function (configuredPlugin) {
-    ctx.plugins.eachEnabledPlugin(function (plugin){
+    ctx.plugins.eachEnabledPlugin(function (plugin) {
       if (plugin.virtAsst) {
         if (plugin.virtAsst.intentHandlers) {
           console.log('Plugin "' + plugin.name + '" supports Virtual Assistants');

diff --git a/tests/dbsize.test.js b/tests/dbsize.test.js
@@ -300,18 +300,13 @@ describe('Database Size', function() {
     var dbsize = require('../lib/plugins/dbsize')(ctx);
     dbsize.setProperties(sbx);
 
-    dbsize.virtAsst.intentHandlers.length.should.equal(2);
+    dbsize.virtAsst.intentHandlers.length.should.equal(1);
 
     dbsize.virtAsst.intentHandlers[0].intentHandler(function next (title, response) {
       title.should.equal('Database file size');
-      response.should.equal('450 MiB that is 90% of available database space');
+      response.should.equal('450 MiB. That is 90% of available database space.');
 
-      dbsize.virtAsst.intentHandlers[1].intentHandler(function next (title, response) {
-        title.should.equal('Database file size');
-        response.should.equal('450 MiB that is 90% of available database space');
-
-        done();
-      }, [], sbx);
+      done();
 
     }, [], sbx);