This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Actually use our linker as the linker for sample/fastLinkJS. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
true-linker-backend
branch
6 times, most recently
from
5a392db
to
4d9423d
Compare
sjrd
changed the title
We will need the Wasm backend to be built for 2.12.x in order to load it as a true linker from the sbt build.
This way, we do not depend on Scala.js-specific APIs.
An `OutputDirectory` is not supposed to be shared.
And delete stray files in the output directories, as is mandated by the contract of a linker backend.
This follows the architecture of the Scala.js linker.
In addition to emitting the `.wasm` and `.wat` files in the output directory, we now also emit emit the internal `__loader.js` file, and the public module specified by the `ModuleSet`, such as `main.js`. We embed the content of the loader as a constant string in the backend, so that it works both on the JVM and on JS. Eventually, we will probably generate it more dynamically from `backend.javascript.Trees` anyway, so this not really a big deal. This change requires to adapt the loading mechanism to force URL resolution against the base directory of the `loader.js` file, rather than the working directly. We do this thanks to `import.meta.url`, which is also available in browsers. As is, this change destroys the semantics of top-level exported `var`s. Mutations performed after the module initializers have completed will not be reflected in the exports of `main.js`. We will need to revisit this later on, with a technique similar to the one used by the JS backend. With these changes, our linker backend actually abides by the specification of a `LinkerBackend`, which means we will be able to directly use it from sbt.
sjrd
force-pushed
the
true-linker-backend
branch
from
4d9423d
to
073715d
Compare
|
Rebased on top of #50. |
tanishiking
approved these changes
Apr 1, 2024
cli/src/main/scala/Main.scala
Outdated
Comment on lines
67
to
70
| val linker = WebAssemblyLinkerImpl.linker(linkerConfig) | ||
| val outputDir = "./target/sample/" | ||
| createDir(outputDir) | ||
| val output = NodeOutputDirectory(outputDir) |
There was a problem hiding this comment.
This else branch is no longer needed. When we run sample/fastLinkJS, it's going to be handled by WasmLInkerPlugin.
Maybe we can remove this branch? I was a bit confused why sample/fastLinkJS doesn't generate output under ./target/sample.
There was a problem hiding this comment.
Good point. I removed it.
Now, `sample/fastLinkJS` uses our WebAssembly linker, and `sample/run` actually executes the `main` method of the sample project, linked to WebAssembly.
sjrd
force-pushed
the
true-linker-backend
branch
from
073715d
to
b1b51ed
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, just to get the CI to run.Main changes:
wasmproject.Compilerinto a linker that actually implements theLinkerandLinkerBackendinterfaces of Scala.js.sampleproject to use our WebAssembly linker insample/fastLinkJS(and therefore insample/run).