Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Local cleanups in ClassEmitter. #132

Merged
merged 14 commits into from
May 17, 2024
Merged

Local cleanups in ClassEmitter. #132

merged 14 commits into from
May 17, 2024

Commits on May 17, 2024

  1. Rename ClassEmitter.transformX methods to genX. 

    Everything else that generates code is called `genX` at this point.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8bff689 View commit details
    Browse the repository at this point in the history

  2. Remove genHijackedClass. 

    It has been a no-op for a while.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    fa6ee1d View commit details
    Browse the repository at this point in the history

  3. Merge genClass and genModuleClass into genClassCommon. 

    Which we rename to genScalaClass.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8105283 View commit details
    Browse the repository at this point in the history

  4. Deduplicate generation of typeData for abstract classes.

    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3338e6e View commit details
    Browse the repository at this point in the history

  5. Inline genField into genScalaClass. 

    That centralizes building of all the `StructField`s of a class'
struct type.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    cd64997 View commit details
    Browse the repository at this point in the history

  6. Integrate the two overloads of genTypeDataFieldValues. 

    Since one was the only caller of the other.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    593d43c View commit details
    Browse the repository at this point in the history

  7. Factor out more behavior into genTypeDataGlobal.

    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    cc71fa5 View commit details
    Browse the repository at this point in the history

  8. Rename genLoadModuleFunc to genModuleAccessor. 

    This corresponds to how it is called in the JS backend.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c9ca55c View commit details
    Browse the repository at this point in the history

  9. Hard-code the constructor name in genModuleAccessor. 

    By spec, the constructor to call for a module class is always
`<init>()`, i.e., `NoArgConstructorName`.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    55e203b View commit details
    Browse the repository at this point in the history

  10. Inline genITableGlobal into genGlobalClassItable. 

    It was its only call site, and separating it does not help.
    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    340bbd7 View commit details
    Browse the repository at this point in the history

  11. Replace a find by an exists.

    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6b61f35 View commit details
    Browse the repository at this point in the history

  12. Remove some useless implicit val pos.

    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c47dd70 View commit details
    Browse the repository at this point in the history

  13. Remove a useless lookup of getClassInfo.

    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3d97dd4 View commit details
    Browse the repository at this point in the history

  14. Remove obsolete comment.

    @sjrd
    sjrd committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ce367d1 View commit details
    Browse the repository at this point in the history