This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Reorganize the emitter to better match the JS backend. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…smBuilder. This is in the context of making `WasmBuilder` closer to the JS back-end `ClassEmitter` and `HelperFunctions` closer to `CoreJSLib`. The former is responsible for the generation of everything that relates to a given `LinkedClass`, while the latter is responsible for generating everything that is more global.
We are going to give it the same kinds of responsibilities as `CoreJSLib` for the JS back-end.
This corresponds to the JS backend, where all definitions that are not related to any particular class are handled by `CoreJSLib`.
It now has the same responsibilities as the `ClassEmitter` in the JS backend.
It has the same responsibilities as `Emitter` in the JS backend, namely handling the macro-structure of the output files, but not I/O operations.
This way, WasmContext is not responsible for emitting code anymore. It only acts as a knowledge repository.
sjrd
changed the title
tanishiking
approved these changes
May 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.