Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Support transformation of hijacked classes. #10

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

sjrd
Copy link
Collaborator

@sjrd sjrd commented Mar 7, 2024

This removes the last remaining exclude filters we had, including on the list of methods of j.l.Object.

sjrd added 4 commits March 7, 2024 09:42
When the expression's type is a subtype of the target type of the
`AsInstanceOf`, it is a no-op.
This way, we can remove them from the exclude list. The only
remaining class to be excluded is `java.lang.Class`.
This way, `j.l.Class` is not reachable, nor the other problematic
methods of `j.l.Object`. This means we can remove the last filters
and only rely on reachability analysis.
Copy link
Owner

@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +233 to +234
} else if (receiverClassInfo.kind == ClassKind.HijackedClass) {
// statically resolved call
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tanishiking tanishiking merged commit b3701b9 into tanishiking:main Mar 8, 2024
1 check passed
@sjrd sjrd deleted the enable-hijacked-classes branch March 8, 2024 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants