Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up for CMake scripts and Windows platform #2287

Merged
merged 11 commits into from
Sep 7, 2021
Merged

Clean up for CMake scripts and Windows platform #2287

merged 11 commits into from
Sep 7, 2021

Conversation

matteblair
Copy link
Member

@matteblair matteblair commented Aug 15, 2021 •
edited
Loading

  • Adds new function Url::fromWindowsFilePath so that the Url constructor doesn't need platform-dependent behavior.
  • Adds new function YamlUtil::loadNoCopy so that Importer doesn't need platform-dependent behavior.
  • Normalized vcpkg integration so that any platform can use vcpkg dependencies by configuring CMake with a vcpkg toolchain file.

@matteblair matteblair force-pushed the cmake-windows-cleanup branch from a5b73ed to 74554ae Compare September 4, 2021 22:38
@matteblair matteblair merged commit e5d706a into main Sep 7, 2021
@matteblair matteblair deleted the cmake-windows-cleanup branch September 7, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matteblair