Reduce allocations in JNI invocations #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactoring Tangram's JNI usage for the Android SDK a while ago, I noticed opportunities for avoiding a lot of temporary allocations for objects used exclusively to send data between Java and C++. The general pattern here is that rather than passing a Java object's data as primitives in a list of arguments, we can pass the Java objects into JNI methods and use field accessors to get or set the data directly in C++. This requires a bit more boilerplate code to set up field IDs in C++, but minimizing temporary allocations is important for performance and I think several methods are much easier to read now.