Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android JNI Refactor #2187

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Android JNI Refactor #2187

merged 4 commits into from
Oct 21, 2020

Conversation

matteblair
Copy link
Member

@matteblair matteblair commented Sep 14, 2020

  • Native methods removed from MapController into separate NativeMap class
  • NativeMap stores pointer to cpp objects in private field
  • NativeMap checks pointer once at initialization, afterwards native methods are called without passing in pointer
  • In cpp implementation of NativeMap methods, pointer field is accessed via JNI
  • AndroidPlatform and AndroidMap split into separate files
  • Functionality shared between AndroidPlatform and AndroidMap moved into JniHelpers
  • cpp files renamed to match class names
  • Unnecessary fields in MapController converted to local variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant