-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclusive and Priority for SceneLayer #2046
Conversation
6bb0d8a
to
cfb40ac
Compare
- Sort SceneLayers such that all exclusive layers come before non-exclusive layers and in order of increasing priority
cfb40ac
to
d398335
Compare
After a year in limbo, this PR is finally ready! This now implements the The scene layer sorting in this implementation looks a bit different than that in the Tangram JS implementation (tangrams/tangram#705). This is because we have a different way of traversing the layer tree when evaluating rules for a feature. Basically, when draw rules are being merged we keep the first value that is set for a parameter, unless the new one is from a greater depth. So, for sibling layers to follow the rules of |
This is looking good to go! The one thing I've found from starting to use this feature is that I frequently encounter layers where every sublayer can or should be |
Sorry COVID-19 situation means I rarely get cycles to check tangram notifications. This looks good to me and thanks a lot @matteblair for continuing this work from where I left off! |
non-exclusive layers and in order of increasing priority
TODO:
priority
andexclusive
properties.Resolves #2036