Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blueprint-proc-macro): set tokio crate in sdk::main #502

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix(blueprint-proc-macro): set tokio crate in sdk::main #502

merged 1 commit into from
Nov 27, 2024

Conversation

Serial-ATA
Copy link
Contributor

So that blueprints don't have to explicitly depend on tokio.

@Serial-ATA
fix(blueprint-proc-macro): set tokio crate in sdk::main
f1aec01 
So that blueprints don't have to explicitly depend on `tokio`.
@Serial-ATA Serial-ATA requested a review from tbraun96 November 27, 2024 16:37
@Serial-ATA
Copy link
Contributor Author

CI failure is unrelated. Apparently it's an error to have no tests to run?

@drewstone
Copy link
Contributor

CI has not tests to run?

@Serial-ATA
Copy link
Contributor Author

nextest is failing in blueprint-manager, apparently it has no tests.

@drewstone drewstone merged commit dcd1cac into main Nov 27, 2024
8 of 13 checks passed
@webb-spider webb-spider bot mentioned this pull request Nov 27, 2024
Merged
@Serial-ATA Serial-ATA deleted the serial/macro-tokio branch November 27, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

@tbraun96 tbraun96 Awaiting requested review from tbraun96

Assignees
No one assigned
Labels
None yet
Projects
Webb Universe
Status: Completed ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Serial-ATA @drewstone @shekohex