Dev patches #364
Closed
Dev patches #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
commented
Mar 12, 2022
|
|
||
| jobs: | ||
| release: | ||
| if: "!contains(github.event.head_commit.message, 'skip ci') && github.repository == 'tancredi/fantasticon'" |
There was a problem hiding this comment.
Closed
|
@tancredi friendly ping, please check the OP |
|
@tancredi ping |
* switch to the latest OS versions * update actions/checkout to v3 * update actions/setup-node to v3 * switch to native caching * exclude dependabot from pushes since it always opens a PR * add `workflow_dispatch` * add `persist-credentials: false` * remove no longer needed `skip ci` check since it's now built in
|
Closing, and moving the changes to @twbs/fantasticon. It's a shame that contributions go in vain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tancredi
Please do not change my patches when merging (the commit messages might need to be adapted, though). After this PR is merged, a new MAJOR version needs to be made :)
As for dependabot, you should comment in the PRs to ignore packages from now on, instead of keeping a huge list of deps to ignore here.
Regarding the actions, all changes are tested and should be safe. Please do not change the patches. :)
EDIT: branch protection rules need cleanup and adaptation.
Fixes #470 along the way