Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extension determination algorithm update. #309

Closed
exislow opened this issue Dec 16, 2024 · 7 comments
Closed

File extension determination algorithm update. #309

exislow opened this issue Dec 16, 2024 · 7 comments

Comments

@exislow
Copy link
Contributor

exislow commented Dec 16, 2024

There have been some changes on TIDALs side. Hence, I need to update the file extension determination algorithm. TIDAL now streams files with ".m4a" instead of "mp4" as extension. I will get you an PR.

@exislow
Copy link
Contributor Author

exislow commented Dec 16, 2024

@tehkillerbee would be great, if you could have a look at it. Maybe worth a hot fix release.

tehkillerbee added a commit that referenced this issue Dec 18, 2024
✨ Extended file extension detection to properly detect M4A files. Fixes #309
@exislow
Copy link
Contributor Author

exislow commented Dec 18, 2024

By any chance: Do already have a date for the next release?

@exislow
Copy link
Contributor Author

exislow commented Dec 20, 2024

@tamland: Forgot to mention you in my question above.

@tehkillerbee
Copy link
Collaborator

Not sure if you meant to tag me or tamland. Anyways, I will most likely update the release during the holidays.

Otherwise, if you prefer "bleeding edge", you can always point to the latest master it in your dependency, similar to this example:

[tool.poetry.dependencies]
python = "^3.6"
ansible = { git = "https://github.com/ansible/ansible.git", branch = "devel" }
# or
ansible = { git = "https://github.com/ansible/ansible.git", tag = "v2.6.6" }
# or
ansible = { git = "https://github.com/ansible/ansible.git", rev = "e5664c4" }

@exislow
Copy link
Contributor Author

exislow commented Dec 20, 2024

@tehkillerbee have just seen, that only you are mentioned in the README as the only active maintainer, sorry for that.

PyPi does not accept hotlinks to git repositories, if I try to publish a new release. But I can wait a few days. Do not worry and thanks a lot!

@exislow
Copy link
Contributor Author

exislow commented Dec 29, 2024

Which holidays did you exactly mean btw? :)

@tehkillerbee
Copy link
Collaborator

@exislow I was working on it, right as you wrote. Updated to latest release now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants