New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event onLoadFailure should know parameters from did-fail-load #71

Open

k2s wants to merge 1 commit into tamkeen-tms:release-v1.0.6 from k2s:onLoadFailure

k2s commented Jan 14, 2019

Electron did-fail-load may fire on any script on loaded page
for example errorCode===-3 (Aborted) could happen when some script is still downloading and page starts to navigate elsewhere
this change will provide all available parameters from did-fail-load to onLoadFailure event handler as second parameter
I based my branch on latest 1.0.6 release, but it should be merget also to master

Example:

onLoadFailure: function (window, didFailParams) 
    if (didFailParams && (!didFailParams.isMainFrame || didFailParams.errorCode === -3)) {
      log.debug(`onLoadFailure ignored: ${didFailParams.validatedURL}`)
      return
    }
  // ...
}


          change pass information from did-fail-load to onLoadFailure event

8230dbc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet