Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill missing members for Records #128

Closed
michaelschufi opened this issue Mar 23, 2021 · 4 comments
Closed

Fill missing members for Records #128

michaelschufi opened this issue Mar 23, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@michaelschufi
Copy link

michaelschufi commented Mar 23, 2021

Hi @tamj0rd2

Thanks for this extension :-)

I frequently create mapping objects doing something similar to this:

type MyUnionType = "some" | "strings";

interface MyInterface {
  field: "Foo" | "Bar" | "Foo Bar";
}

const myObject: Record<"foo", string> = {};
const myObject2: Record<MyInterface["field"], MyUnionType> = {};

But this is not yet supported.

This may have something to do with #122

@tamj0rd2 tamj0rd2 added the enhancement New feature or request label Mar 23, 2021
@tamj0rd2
Copy link
Owner

tamj0rd2 commented Mar 23, 2021

Thanks for flagging this with a clear example. I'll have a look into it!

@tamj0rd2 tamj0rd2 changed the title Adding members to Records is not working Fill missing members for Records Mar 23, 2021
@tamj0rd2 tamj0rd2 added the help wanted Extra attention is needed label Mar 24, 2021
@tamj0rd2
Copy link
Owner

records

This is coming out in the next release of the extension which should be available at some point in the next day. Let me know if you have any issues

github-actions bot pushed a commit that referenced this issue Apr 10, 2021
# [ts-quickfixes-plugin-v1.8.0](ts-quickfixes-plugin-v1.7.0...ts-quickfixes-plugin-v1.8.0) (2021-04-10)

### Features

* add basic support for Records ([fa38756](fa38756)), closes [#128](#128)
@tamj0rd2
Copy link
Owner

🎉 This issue has been resolved in version ts-quickfixes-plugin-v1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@michaelschufi
Copy link
Author

michaelschufi commented Apr 11, 2021

Looks awesome :D Thank you! I will try it out tomorrow :)

Edit: Works flawlessly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Development

No branches or pull requests

2 participants