Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameFinderTest.removeConflicts(..) guard against empty list. #13

Closed
drewfarris opened this issue Sep 8, 2013 · 1 comment
Closed

NameFinderTest.removeConflicts(..) guard against empty list. #13

drewfarris opened this issue Sep 8, 2013 · 1 comment

Comments

@drewfarris
Copy link
Collaborator

If the removeConflicts method from NameFinderTest is called with an empty list an exception is thrown.

There's really no need to do anything in removeConflicts unless we have more than one item passed into the method via the list argument, so exit early if the list has less than 2 entries.
drewfarris added a commit that referenced this issue Sep 8, 2013
@drewfarris
Fix for #13 - add bounds check the size of the list passed into remov…
2b2702d 
…e conflicts
@drewfarris
Copy link
Collaborator Author

Thanks to Rick who posted the original issue on:
http://www.manning-sandbox.com/thread.jspa?messageID=148021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drewfarris