Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.3: Fix issue with FrontendStateEnum and StateEnum for campaign notifications #37

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

giou-k
Copy link
Member

@giou-k giou-k commented Jul 5, 2023

Summary

Issue 1:

And the second issue was that FrontendState is not being used properly by the java sdk. To fix this we introduced CampaignStateNotification in the respective .java obejcts.

In more detail see:

  • Fix for FrontendState
    Because the link doesn't work, please see src/main/java/one/talon/model/CampaignEditedNotification.java
public class CampaignEditedNotification {
  public static final String SERIALIZED_NAME_CAMPAIGN = "campaign";
  @SerializedName(SERIALIZED_NAME_CAMPAIGN)
  private CampaignStateNotification campaign;

and then
CampaignStateNotification.java -> FrontendStateEnum

Explanation: Above we see that the CampaignEditedNotification encapsulates CampaignStateNotification, which encapsulates FrontendStateEnum.

Issue 2:

This PR includes (because of the generate process) another fix that is worth mentioning:

The initial issue that was reported by the TAM is that we are missing the extra 5 enums while we get a notificaiton on campaign state changed. This was hacky fixed at 5.0.2.

At 5.0.3 we introduce CampaignForNotification.javafor campaign state changed to fix the above mentioned issue.

In more detail see:

  • Fix for StateEnum
    Because the link doesn't work, please see src/main/java/one/talon/model/CampaignForNotification.java line 79 (StateEnum)

The equivalent swagger change in talon-service can be found here

@giou-k giou-k requested a review from altJake July 5, 2023 10:34
@giou-k giou-k requested review from altJake, kkupreeva, rubyjohn93, gotgelf and ahmetildirim and removed request for altJake July 26, 2023 14:29
@merent1
Copy link

merent1 commented Aug 21, 2023

[sc-26314]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #26314: Fix issue with FrontendState in TalonJavaSDK repo.

@giou-k giou-k merged commit 624a215 into master Aug 25, 2023
giou-k added a commit that referenced this pull request Aug 25, 2023
v5.0.3: Fix issue with FrontendStateEnum and StateEnum for campaign notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants