v5.0.3: Fix issue with FrontendStateEnum and StateEnum for campaign notifications #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue 1:
And the second issue was that
FrontendState
is not being used properly by the java sdk. To fix this we introducedCampaignStateNotification
in the respective.java obejcts
.In more detail see:
Because the link doesn't work, please see
src/main/java/one/talon/model/CampaignEditedNotification.java
and then
CampaignStateNotification.java
->FrontendStateEnum
Explanation: Above we see that the
CampaignEditedNotification
encapsulatesCampaignStateNotification
, which encapsulatesFrontendStateEnum
.Issue 2:
This PR includes (because of the generate process) another fix that is worth mentioning:
The initial issue that was reported by the TAM is that we are missing the extra 5 enums while we get a notificaiton on
campaign state changed
. This was hacky fixed at5.0.2
.At
5.0.3
we introduceCampaignForNotification.java
forcampaign state changed
to fix the above mentioned issue.In more detail see:
Because the link doesn't work, please see
src/main/java/one/talon/model/CampaignForNotification.java
line 79 (StateEnum)The equivalent swagger change in talon-service can be found here