feat: new option to change headers addition behavior #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwhitworth Could you review this PR too, please? |
mwhitworth
force-pushed
the
feat/new-option-to-change-headers-addition-behavior
branch
from
49593c6
to
957681e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the use case we have using this library, we want to have the same behavior if we change the response_mode when adding upstream headers to the current conn, today this is not true.
When we use
response_mode: :streamthe code add headers withPlug.Conn.put_resp_header/3that replace the headers that already exists in the conn.When we use
response_mode: :bufferthe code add headers withPlug.Conn.prepend_resp_headers/2that prepends the upstream headers in the conn resp headers.This PR attempts to resolve this issue by adding a new option to change the header addition behavior according to response_mode. And set the default options to values that will be backwards compatible.
And I think this PR also helps to solve this issue #165.