Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes transfer-encoding header from responses with non compliant status codes #151

Conversation

jhonndabi
Copy link
Contributor

Transfer-Encoding header violates RFC 7230:

https://datatracker.ietf.org/doc/html/rfc7230#section-3.3.1

A server MUST NOT send a Transfer-Encoding header field in any response with a status code of 1xx (Informational) or 204 (No Content).

We are having trouble to update our service mesh, because the new version are dropping requests, that are not compliant with the HTTP spec.

And I think this PR also resolves this issue #36

@jhonndabi jhonndabi changed the title fix: removes transfer-encoding header from responses with non compliant status codes Removes transfer-encoding header from responses with non compliant status codes Oct 5, 2022
@victorolinasc
Copy link

Hi @tallarium-bot @mwhitworth @Fedjmike! This seems pretty straight-forward and important for being more conformant with the spec. Do you think this can be merged and released?

@mwhitworth mwhitworth merged commit b103889 into tallarium:master Oct 25, 2022
@jhonndabi jhonndabi deleted the fix/removes-transfer-encoding-header-from-non-compliant-statuses branch October 25, 2022 14:04
@jhonndabi jhonndabi restored the fix/removes-transfer-encoding-header-from-non-compliant-statuses branch October 25, 2022 14:05
@jhonndabi jhonndabi deleted the fix/removes-transfer-encoding-header-from-non-compliant-statuses branch November 20, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants