Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defines Endpoint enum to avoid using hardcoded strings as endpoints #173

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

sr-gi
Copy link
Member

@sr-gi sr-gi commented Jan 19, 2023

Useful for both the tower API and the clients.

This is currently building on top of #160, so we'll need to merge that first.

@sr-gi sr-gi added feature request New feature or request easy to review easypeasy labels Jan 19, 2023
@sr-gi sr-gi force-pushed the endpoints branch 2 times, most recently from cb5beb6 to 500b483 Compare January 19, 2023 19:54
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Useful for both the tower API and the clients
@sr-gi
Copy link
Member Author

sr-gi commented Jan 20, 2023

Rebased to branch from master after merging #160

@sr-gi sr-gi merged commit b035a3e into talaia-labs:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy to review easypeasy feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants