We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, I found unnecessary check code in o.t.doublearray.DoubleArray and o.t.doublearray.TailDoubleArray``#getChild method.
o.t.doublearray.DoubleArray
o.t.doublearray.TailDoubleArray``#getChild
public DoubleArrayNode getChild(char c) { int code = charToCode[c]; if (code == -1) return null; int nid = base[nodeId] + code;
Here charToCode is defined char[] and char is ranging from 0x0000 to 0xffff in language specification and never be negative.
charToCode
char[]
char
I think it can be like
public DoubleArrayNode getChild(char c) { int nid = base[nodeId] + charToCode[c];
I found it when I check the project by SpotBugs, the above code produce an error.
The text was updated successfully, but these errors were encountered:
fix issue #42
c6219e4
Thanks again! I modified the code and added some tests.
Sorry, something went wrong.
No branches or pull requests
Hi, I found unnecessary check code in
o.t.doublearray.DoubleArray
ando.t.doublearray.TailDoubleArray``#getChild
method.Here
charToCode
is definedchar[]
andchar
is ranging from 0x0000 to 0xffff in language specification and never be negative.I think it can be like
I found it when I check the project by SpotBugs, the above code produce an error.
The text was updated successfully, but these errors were encountered: