Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2024 12 fixed single column insert #343

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

takapi327
Copy link
Owner

@takapi327 takapi327 commented Dec 23, 2024

Implementation Details

Fixed an issue where an Insert statement with a single column would result in a compile error.

query.insertInto(_.id).values(1)
[error] 32 |    query.insertInto(_.id).values(1)
[error]    |                           ^
[error]    |       Tuple element types must be known at compile time
[error]    |----------------------------------------------------------------------------
[error]    |Inline stack trace
[error]    |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
[error]    |This location contains code that was inlined from Encoder.scala:96
[error]    |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
[error]    |This location contains code that was inlined from Encoder.scala:96
[error]     ----------------------------------------------------------------------------
[error] one error found
[error] (Compile / compileIncremental) Compilation failed

Pull Request Checklist

  • Wrote unit and integration tests
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code formatting by scalafmt (sbt scalafmtAll command execution)
  • Add copyright headers to new files

References

@takapi327 takapi327 added 🪲 bug Something isn't working project:statement Addition and modification of functionality to Statement projects labels Dec 23, 2024
@takapi327 takapi327 added this to the 0.3.0 milestone Dec 23, 2024
@takapi327 takapi327 self-assigned this Dec 23, 2024
@takapi327 takapi327 merged commit daf5228 into master Dec 23, 2024
27 checks passed
@takapi327 takapi327 deleted the bugfix/2024-12-Fixed-Single-column-insert branch December 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working project:statement Addition and modification of functionality to Statement projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant