Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete cardinality property #310

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

takapi327
Copy link
Owner

Implementation Details

Since MySQL generates cardinality values based on statistics, they may not be accurate.

MySQL generates the index cardinality based on statistics stored as integers, therefore, the value may not be necessarily > exact.

https://www.mysqltutorial.org/mysql-index/mysql-index-cardinality

This is why tests sometimes fail. Testing with unstable elements is a waste of time and effort, and there should be no need to check cardinality values if you know you can get data.

==> X ldbc.tests.LdbcDatabaseMetaDataTest.ldbc: getIndexInfo  0.011s munit.ComparisonFailException: /home/runner/work/ldbc/ldbc/tests/src/test/scala/ldbc/tests/DatabaseMetaDataTest.scala:1782
1781:      )
1782:    )
1783:  }
values are not the same
=> Obtained
Vector(
  "connector_test, null, tax, false, null, PRIMARY, 3, 1, id, A, 2, 0, null"
)
=> Diff (- obtained, + expected)
 Vector(
-  "connector_test, null, tax, false, null, PRIMARY, 3, 1, id, A, 2, 0, null"
+  "connector_test, null, tax, false, null, PRIMARY, 3, 1, id, A, 3, 0, null"
 )

Fixes

Fixes #xxxxx

Pull Request Checklist

  • Wrote unit and integration tests
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code formatting by scalafmt (sbt scalafmtAll command execution)
  • Add copyright headers to new files

References

@takapi327 takapi327 added the 🪲 bug Something isn't working label Oct 10, 2024
@takapi327 takapi327 added this to the 0.3.0 milestone Oct 10, 2024
@takapi327 takapi327 self-assigned this Oct 10, 2024
@takapi327 takapi327 merged commit d2cb5f2 into master Oct 10, 2024
25 checks passed
@takapi327 takapi327 deleted the bug/2024-10-Fixes-problems-with-test-failures branch October 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant