Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added childPortals functionality #101 #102

Closed
wants to merge 1 commit into from

Conversation

woodenconsulting
Copy link

No description provided.

@tajo
Copy link
Owner

tajo commented Dec 29, 2016

Any description? Use-cases? Examples? Tests?

Sorry for not responding sooner.
Thank you.

EDIT: Sorry, I missed #101 but still this PR missing tests.

@ashelley
Copy link

Hello @woodenconsulting, just curious if you could post an example of using the childportal props for supporting nesting and properly handling not closing when clicking within a childPortal of a portal.

Thanks!

@tajo
Copy link
Owner

tajo commented Oct 1, 2017

Hey, please check the new major version (complete rewrite) of react-portal: #157

It's React v16 only since its uses the new official Portal API. There is the first beta released and I would like to get your feedback. I don't have bandwidth to maintain v3 which is very different and full of hacks.

If you feel your PR still applies, please rebase it against the master and re-open it. Sorry for the lack of response in past! Thanks!

@tajo tajo closed this Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants