-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't apply margins to <br>
elements contained in an <li>
in FF
#350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of these selectors are to only target `p` tags but we are targeting `*:first-child` and `*:last-child`. This has a side effect of causing `<br>` elements inside the list item to gain a margin _only in Firefox_. Other browsers treat the `<br>` element as properly inline and as such don’t apply margins but FF does not seem to.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
changed the title
Only fixup margins in
Don't apply margins to Apr 23, 2024
p
tags when inside a list item<br>
elements contained in an <li>
in FF
adamwathan
approved these changes
Apr 24, 2024
This was referenced Jul 27, 2024
This was referenced Oct 8, 2024
This was referenced Oct 15, 2024
This was referenced Oct 22, 2024
This was referenced Nov 2, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the following would have unexpected extra space between the two lines of text in Firefox (but not in Safari or Chrome):
Before, in FF:
After, in FF — now matching other browsers:
The intent of the selectors I've changed were to target leading/trailing
p
tags in a list item but we are targeting*
instead. This had the side effect of causing<br>
elements inside list items to gain a margin only in Firefox. Other browsers treat the<br>
element like any other inline element and as such don’t apply margins.Fixes #349