-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve detection of string concatenation #288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
Improve concat expression detection
Improve detection of string concatenation
Jun 7, 2024
RobinMalfait
approved these changes
Jun 11, 2024
Co-authored-by: Robin Malfait <[email protected]>
Co-authored-by: Robin Malfait <[email protected]>
Co-authored-by: Robin Malfait <[email protected]>
thecrypticace
force-pushed
the
feat/better-whitespace-bailout
branch
from
June 11, 2024 14:41
42a53c3
to
25c5438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd check to see if a string literal was immediately nested inside a concat expression, for example:
However, this breaks down when the strings being sorted are nested inside other expressions. For example, a ternary expression:
The way this works is if a string is nested inside a concat expression at any level then we'll do our best to keep the relevant whitespace. Obviously, due to runtime evaluation, we can't guarantee that all necessary whtiespace will be preserved, or that all unnecessary whitespace will be removed, but this improves the situation for the vast majority of cases.
Fixes #285
This depends on #287 and that PR must be merged first