feat: type declarations for vue #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacoto97
approved these changes
Apr 20, 2021
|
Can this be merged, please? |
|
This fixes broken support for tailwind UI and was approved a month ago. Pls merge. |
|
no idea |
|
Pinging @bradlc and @adamwathan again. |
|
@bradlc @adamwathan Please can you merge this? |
dacoto97
approved these changes
Jul 25, 2021
|
Hey! Thank you for your PR! Sorry for the delay! |
zmwangx
added a commit
to zmwangx/heroicons
that referenced
this pull request
Aug 1, 2021
The declarations generated by tailwindlabs#254 aren't correct, leading to tsc errors as seen in tailwindlabs#318.
bradlc
added a commit
that referenced
this pull request
Aug 17, 2021
* Fix vue TS declarations The declarations generated by #254 aren't correct, leading to tsc errors as seen in #318. * Use `RenderFunction` instead of `DefineComponent` Co-authored-by: Brad Cornes <[email protected]>
This was referenced Sep 11, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #252
Until this is merged, I've published a package heroicons-vue3,
which will be deprecated (but will continue to work, however unmaintained) once it is merged. If you need to use Heroicons with Vue 3 now, you can use that for the time being.